[webkit-reviews] review granted: [Bug 72048] --webkit-visual-word should be able to reach end of text, instead of end of line : [Attachment 117040] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 72048: --webkit-visual-word should be able to reach end of text, instead of
end of line
https://bugs.webkit.org/show_bug.cgi?id=72048

Attachment 117040: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=117040&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117040&action=review


> Source/WebCore/editing/visible_units.cpp:1615
> +    // FIXME: how to handle non-editable position?

"How should we handle a non-editable position"

> Source/WebCore/editing/visible_units.cpp:1616
> +    if (leftWordBreak.isNull() &&
isEditablePosition(visiblePosition.deepEquivalent())) {

Please use visiblePosition.rootEditableElement() instead.

> Source/WebCore/editing/visible_units.cpp:1631
> +    // FIXME: how to handle non-editable position?

Ditto.

> Source/WebCore/editing/visible_units.cpp:1632
> +    if (rightWordBreak.isNull() &&
isEditablePosition(visiblePosition.deepEquivalent())) {

Ditto.