[webkit-reviews] review granted: [Bug 73352] Use contentsToRootView when converting the mouse coordinates for the context menu key event : [Attachment 117033] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 29 13:23:47 PST 2011
Adam Roben (:aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 73352: Use contentsToRootView when converting the mouse coordinates for the
context menu key event
https://bugs.webkit.org/show_bug.cgi?id=73352
Attachment 117033: Patch
https://bugs.webkit.org/attachment.cgi?id=117033&action=review
------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117033&action=review
> Source/WebCore/ChangeLog:12
> + Use contentsToRootView when converting the mouse coordinates for the
context menu key event
> + https://bugs.webkit.org/show_bug.cgi?id=73352
> +
> + Reviewed by NOBODY (OOPS!).
> +
> + This is another step towards fixing
https://bugs.webkit.org/show_bug.cgi?id=71945, by getting
> + rid of a call to ScrollView::contentsToWindow.
> +
> + * page/EventHandler.cpp:
> + (WebCore::EventHandler::sendContextMenuEventForKey):
You should mention why you haven't modified/added any tests.
More information about the webkit-reviews
mailing list