[webkit-reviews] review requested: [Bug 73346] [chromium] add accessors to WebDOMMessageEvent : [Attachment 117029] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 29 13:11:40 PST 2011
Karl Koscher <supersat at chromium.org> has asked for review:
Bug 73346: [chromium] add accessors to WebDOMMessageEvent
https://bugs.webkit.org/show_bug.cgi?id=73346
Attachment 117029: Patch
https://bugs.webkit.org/attachment.cgi?id=117029&action=review
------- Additional Comments from Karl Koscher <supersat at chromium.org>
(In reply to comment #3)
> (From update of attachment 117016 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=117016&action=review
>
> > Source/WebKit/chromium/public/WebDOMMessageEvent.h:50
> > + WEBKIT_EXPORT WebString data() const;
>
> nit: This method should probably return WebSerializedScriptValue instead.
Fixed.
More information about the webkit-reviews
mailing list