[webkit-reviews] review denied: [Bug 73346] [chromium] add accessors to WebDOMMessageEvent : [Attachment 117016] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 12:57:30 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Karl Koscher
<supersat at chromium.org>'s request for review:
Bug 73346: [chromium] add accessors to WebDOMMessageEvent
https://bugs.webkit.org/show_bug.cgi?id=73346

Attachment 117016: Patch
https://bugs.webkit.org/attachment.cgi?id=117016&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=117016&action=review


> Source/WebKit/chromium/public/WebDOMMessageEvent.h:50
> +    WEBKIT_EXPORT WebString data() const;

nit: This method should probably return WebSerializedScriptValue instead.


More information about the webkit-reviews mailing list