[webkit-reviews] review denied: [Bug 72506] [WebKit2] Web Inspector: window.open should work inside inspector front-end : [Attachment 115600] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 72506: [WebKit2] Web Inspector: window.open should work inside inspector
front-end
https://bugs.webkit.org/show_bug.cgi?id=72506

Attachment 115600: Patch
https://bugs.webkit.org/attachment.cgi?id=115600&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
Sorry for not giving this much thought earlier. But now that I understand what
is going on here, this should not land.

Hooking up the inspected page's UI client to a non-Safari created WKView is a
bad idea (breaking some assumptions that Safari has the WKPage that gets passed
ot its client).

Also windows opened with window.open will be Safari windows, not WebKit
controlled windows. You will have Find in Page and other browser features in
the window.open windows that don't (and shouldn't exist) in the Web Inspector.

We should implement a UIClient in WebKit2 that handles window.open and makes a
WebKit owned window/WKView.

This patch is all about WebKit2, but we should implement this in WebKit also,
which still has the Web Inspector and is used by clients other than Safari.