[webkit-reviews] review denied: [Bug 73338] [Qt] [WK2] QQuickWebView covers QML elements that should be rendered on top. : [Attachment 117009] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 73338: [Qt] [WK2] QQuickWebView covers QML elements that should be rendered
on top.
https://bugs.webkit.org/show_bug.cgi?id=73338

Attachment 117009: Patch
https://bugs.webkit.org/attachment.cgi?id=117009&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=117009&action=review


This needs to be two patches; 1 for purging the tiled-backingstore, and one for
using the QSG node.

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:240
> +	   return QSize(1, 1);

Comment

> Source/WebKit2/UIProcess/API/qt/qquickwebpage.cpp:285
> +    if (!m_textureId) {
> +	   glGenTextures(1, &m_textureId);
> +	   glBindTexture(GL_TEXTURE_2D, m_textureId);
> +	   QImage image(1, 1, QImage::Format_ARGB32);
> +	   image.fill(Qt::transparent);
> +	   glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, 1, 1, 0, GL_RGBA,
GL_UNSIGNED_BYTE, image.constBits());
> +    } else
> +	   glBindTexture(GL_TEXTURE_2D, m_textureId);

nitpick: swap the directives and use early return

> Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:645
> +    callOnMainThread(&NeedTileBuffersRecreateReq,
> +			new
NeedTileBuffersRecreateReqData(m_drawingAreaProxy->page()->process(),
> +							  
m_drawingAreaProxy->page()->pageID()));

For now LayerTreeHostProxyQt is not thread safe anyway; so maybe we should keep
this for later.