[webkit-reviews] review granted: [Bug 73272] CSS Grid Layout: Add support for parsing multiple grid-columns or grid-rows : [Attachment 116867] Proposed change 1: implement the new syntax.

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 73272: CSS Grid Layout: Add support for parsing multiple grid-columns or
grid-rows
https://bugs.webkit.org/show_bug.cgi?id=73272

Attachment 116867: Proposed change 1: implement the new syntax.
https://bugs.webkit.org/attachment.cgi?id=116867&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116867&action=review


> Source/WebCore/css/CSSStyleSelector.cpp:2520
> +    if (type == CSSPrimitiveValue::CSS_PERCENTAGE)
> +	   length = Length(primitiveValue->getDoubleValue(), Percent);
> +	   return true;
> +    }

Missing { here.  I think that confused the style checker.

> Source/WebCore/css/CSSStyleSelector.cpp:2544
> +	   // Handle the special property 'none'.

Nit: You might want the comment to say how you 'none' is different.