[webkit-reviews] review granted: [Bug 73162] Implement [Supplemental] IDL and support it in run-bindings-tests : [Attachment 116880] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 08:49:28 PST 2011


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 73162: Implement [Supplemental] IDL and support it in run-bindings-tests
https://bugs.webkit.org/show_bug.cgi?id=73162

Attachment 116880: Patch
https://bugs.webkit.org/attachment.cgi?id=116880&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116880&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1653
> +			   $implIncludes{"${implementedBy}.h"} = 1;

Do we need to include the header for JS${implementedBy} ?

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1842
> +				   $implIncludes{"${implementedBy}.h"} = 1;

Same question.


More information about the webkit-reviews mailing list