[webkit-reviews] review granted: [Bug 73315] [Qt] Make WebKit/qt build with V8 and Qt 5 : [Attachment 116954] [Qt] Make WebKit/qt build with V8 and Qt 5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 06:06:06 PST 2011


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 73315: [Qt] Make WebKit/qt build with V8 and Qt 5
https://bugs.webkit.org/show_bug.cgi?id=73315

Attachment 116954: [Qt] Make WebKit/qt build with V8 and Qt 5
https://bugs.webkit.org/attachment.cgi?id=116954&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116954&action=review


> Source/WebKit/qt/Api/qwebframe.cpp:697
> +    QJSValue v = engine->newQObject(object); // ### ownership

Why not use FIXME:?


More information about the webkit-reviews mailing list