[webkit-reviews] review denied: [Bug 72353] [SOUP][WK2] Implement the functions to manager cookies in CookieJar for WebKit2 : [Attachment 116885] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Jongseok Yang
<js45.yang at samsung.com>'s request for review:
Bug 72353: [SOUP][WK2] Implement the functions to manager cookies in CookieJar
for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=72353

Attachment 116885: Patch
https://bugs.webkit.org/attachment.cgi?id=116885&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116885&action=review


> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:132
> +	   char* domain =
const_cast<char*>(soup_cookie_get_domain(soupCookie));
> +	   if (domain)

You can just do:

if (char* domain = const_cast<char*>(soup_cookie_get_domain(soupCookie)))

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:133
> +	       hostnames.add(domain);

Whoops. Seems I missed this in my first review. This you are implicitly
converting from from a UTF-8 c string to a String here, which uses the system
locale. For ths kind of thing you need to use String::fromUTF8.

> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:148
> +	   if (domain && g_str_equal(domain, hostNameString.data()))

I think this can be simplified to be if (domain == hostNameString) or
!g_strcmp0(domain,  hostNameString.data()).