[webkit-reviews] review granted: [Bug 73292] [Qt] QQuickWebView gets wrong position after reload : [Attachment 116913] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 29 01:11:03 PST 2011


Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 73292: [Qt] QQuickWebView gets wrong position after reload
https://bugs.webkit.org/show_bug.cgi?id=73292

Attachment 116913: Patch
https://bugs.webkit.org/attachment.cgi?id=116913&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116913&action=review


r=me, but ChangeLog fixes would be nice for landing :)

> Source/WebKit2/ChangeLog:8
> +	   The ensureContentWithinViewportBoundary, animates the current
viewport

Comma not needed here :)

> Source/WebKit2/ChangeLog:9
> +	   item into boundaries. That ofcourse breaks when we try to animate
it,

ofcourse -> of course


More information about the webkit-reviews mailing list