[webkit-reviews] review granted: [Bug 73189] [Chromium] Assertion fails when opening two popup menus : [Attachment 116903] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Jing Zhao
<jingzhao at chromium.org>'s request for review:
Bug 73189: [Chromium] Assertion fails when opening two popup menus
https://bugs.webkit.org/show_bug.cgi?id=73189

Attachment 116903: Patch
https://bugs.webkit.org/attachment.cgi?id=116903&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116903&action=review


> LayoutTests/fast/forms/select-popup-crash.html:42
> +    // Determine the item height.
> +    var sl1 = document.getElementById('sl1');
> +    var sl2 = document.getElementById('sl2');
> +

These lines are not needed.

> LayoutTests/fast/forms/select-popup-crash.html:54
> +    mouseDownOnSelect("sl2");
> +

We had better show a 'PASS' message; debug("PASS if the test didn't crash.");