[webkit-reviews] review denied: [Bug 73189] Assertion fails when opening two popup menus : [Attachment 116875] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Jing Zhao <jingzhao at chromium.org>'s
request for review:
Bug 73189: Assertion fails when opening two popup menus
https://bugs.webkit.org/show_bug.cgi?id=73189

Attachment 116875: Patch
https://bugs.webkit.org/attachment.cgi?id=116875&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116875&action=review


> Source/WebKit/chromium/ChangeLog:7
> +	   Assertion fails when opening two popup menus
> +	   https://bugs.webkit.org/show_bug.cgi?id=73189
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

You should mention the detail of the problem and how to fix it in ChangeLog.

> Source/WebKit/chromium/src/WebViewImpl.cpp:965
> +    if (popupContainer->popupType() == WebCore::PopupContainer::Select)

This 'if' needs {} because the content has two physical lines.

> LayoutTests/fast/forms/select-popup-crash.html:9
> +<script src="script-tests/listbox-selection-2.js"></script>

Please do not have a separated .js file.  select-popup-crash.js should be
folded into select-popup-crash.html.