[webkit-reviews] review granted: [Bug 73269] js-test-pre: don't try to load stylesheet from a web worker : [Attachment 116854] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 73269: js-test-pre: don't try to load stylesheet from a web worker
https://bugs.webkit.org/show_bug.cgi?id=73269

Attachment 116854: Patch
https://bugs.webkit.org/attachment.cgi?id=116854&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116854&action=review


> LayoutTests/ChangeLog:8
> +	   The other DOM-modification functions can be overridden but
> +	   insertStyleSheet is called when js-test-pre loads.

I'm fine with adding the logic to make this file work in workers here. No need
to override IMO. That will just make it harder to maintain the file since the
definitions will be in different places.

> LayoutTests/fast/js/resources/js-test-pre.js:72
> +    if (typeof document !== 'undefined')

I would find this more readable if you made an isWorker helper function that
returned this value.