[webkit-reviews] review granted: [Bug 73261] Some of the results.json files have results/times entries at the directory level : [Attachment 116842] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 73261: Some of the results.json files have results/times entries at the
directory level
https://bugs.webkit.org/show_bug.cgi?id=73261

Attachment 116842: Patch
https://bugs.webkit.org/attachment.cgi?id=116842&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116842&action=review


> Tools/ChangeLog:8
> +	   This is just a bug that go introduced in a temporary push of the
results server.

Nit: go -> got

> Tools/TestResultServer/model/jsonresults.py:86
> +    # Once the data is fixe, this should assert that the directory level
does not have

Nit: fixe -> fixed

> Tools/TestResultServer/model/jsonresults.py:123
> +	       logging.error("Failed to load json results: %s", 
traceback.print_exception(*sys.exc_info()))

Nit: I think there are 2 spaces after the , instead of 1.