[webkit-reviews] review denied: [Bug 71757] WebWorkerRunLoop wrapper around WorkerRunLoop : [Attachment 116819] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 71757: WebWorkerRunLoop wrapper around WorkerRunLoop
https://bugs.webkit.org/show_bug.cgi?id=71757

Attachment 116819: Patch
https://bugs.webkit.org/attachment.cgi?id=116819&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116819&action=review


> Source/WebKit/chromium/public/WebWorkerRunLoop.h:38
> +    WebWorkerRunLoop(WebCore::WorkerRunLoop*);

Any public, non-inline function that is not guarded by WEBKIT_IMPLEMENTATION
needs to be annotated with WEBKIT_EXPORT.

However, this constructor should probably be wrapped with #if
WEBKIT_IMPLEMENTATION
since it is only callable by WebKit.

What is the purpose of exposing operator< and operator==?  Normally, we do not
export operators.  We instead create an "equals" or "compare" function, and
then
provide those operators as inline helper functions (at the WebKit namespace
level).