[webkit-reviews] review granted: [Bug 72829] Pass command line arguments to GDB when debugging a Mac WebKit application : [Attachment 115989] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 12:35:57 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 72829: Pass command line arguments to GDB when debugging a Mac WebKit
application
https://bugs.webkit.org/show_bug.cgi?id=72829

Attachment 115989: Patch
https://bugs.webkit.org/attachment.cgi?id=115989&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=115989&action=review


r=me

> Tools/Scripts/webkitdirs.pm:2075
> -    exec { $gdbPath } $gdbPath, @architectureFlags, $appPath or die;
> +    exec { $gdbPath } $gdbPath, @architectureFlags, $appPath, @ARGV or die;

NOTE:  This conflicts with Attachment 115993 Bug 66902.  This should either
land first, or not at all.


More information about the webkit-reviews mailing list