[webkit-reviews] review granted: [Bug 73040] FloatQuad::isRectilinear() returns false for 180degree rotations : [Attachment 116790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 12:00:07 PST 2011


James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 73040: FloatQuad::isRectilinear() returns false for 180degree rotations
https://bugs.webkit.org/show_bug.cgi?id=73040

Attachment 116790: Patch
https://bugs.webkit.org/attachment.cgi?id=116790&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116790&action=review


> Source/WebKit/chromium/tests/FloatQuadTest.cpp:54
> +	   EXPECT_EQ(true, quad.isRectilinear());

i believe gtest has EXPECT_TRUE and EXPECT_FALSE

> Source/WebKit/chromium/tests/FloatQuadTest.cpp:72
> +	   EXPECT_EQ(false, quad.isRectilinear());

EXPECT_FALSE


More information about the webkit-reviews mailing list