[webkit-reviews] review granted: [Bug 73113] From @keyframes rules with the same name, the last rule should be used : [Attachment 116569] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 11:50:25 PST 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 73113: From @keyframes rules with the same name, the last rule should be
used
https://bugs.webkit.org/show_bug.cgi?id=73113

Attachment 116569: Patch
https://bugs.webkit.org/attachment.cgi?id=116569&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116569&action=review


> LayoutTests/animations/duplicated-keyframes-name.html:31
> +	   -webkit-animation-name: "anim";
> +    }
> +    @-webkit-keyframes "anim" {
> +	   from { left: 50px; }
> +	   to	{ left: 100px; }
> +    }
> +    @-webkit-keyframes "irrelevant" {
> +	   from { left: 150px; }
> +	   to	{ left: 2500px; }
> +    }
> +    @-webkit-keyframes "anim" {
> +	   from { left: 200px; }
> +	   to	{ left: 300px; }
> +    }

Keyframe names are IDENT, not STRING, so should not be quoted.


More information about the webkit-reviews mailing list