[webkit-reviews] review granted: [Bug 73174] Change set 101187 from bug 73154 removed already lower case optimization : [Attachment 116679] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 73174: Change set 101187 from bug 73154 removed already lower case
optimization
https://bugs.webkit.org/show_bug.cgi?id=73174

Attachment 116679: Patch
https://bugs.webkit.org/attachment.cgi?id=116679&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116679&action=review


r=me with one change below.

> Source/JavaScriptCore/runtime/StringPrototype.cpp:1196
> +    return JSValue::encode(jsString(exec, UString(lower)));

lower.release() is the idiom for avoiding refcount churn here.