[webkit-reviews] review granted: [Bug 72946] [GTK] Add WebKitURIResponse to WebKit2 GTK+ API : [Attachment 116749] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 11:23:29 PST 2011


Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 72946: [GTK] Add WebKitURIResponse to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=72946

Attachment 116749: Updated patch
https://bugs.webkit.org/attachment.cgi?id=116749&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116749&action=review


Nice.

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:98
> +	* The URI to which the response will be made.

Maybe change this to "The URI for which the response was made."

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:104
> +							   _("The URI to which
the response will be made."),

Ditto.

> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:182
> + * be 0 if the server provided incorrect or missing Content-Length.

You have "an" after provided.


More information about the webkit-reviews mailing list