[webkit-reviews] review granted: [Bug 63903] dir=auto should imply unicode-bidi:isolate by default : [Attachment 116667] Fixed per Aharon's comment

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Ryosuke Niwa <rniwa at webkit.org>'s request for
review:
Bug 63903: dir=auto should imply unicode-bidi:isolate by default
https://bugs.webkit.org/show_bug.cgi?id=63903

Attachment 116667: Fixed per Aharon's comment
https://bugs.webkit.org/attachment.cgi?id=116667&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=116667&action=review


> Source/WebCore/ChangeLog:9
> +	   http://dev.w3.org/html5/spec/Overview.html#bidirectional-text

It might be better to use a permanent URL here, such as
<http://dev.w3.org/cvsweb/~checkout~/html5/spec/Overview.html?rev=1.5455;conten
t-type=text%2Fhtml#bidirectional-text>.

> Source/WebCore/ChangeLog:11
> +	   Any element other than bdo, textarea, and pre with dir=auto should
use unicode-bidi: -webkit-isolate

“Any element other than bdo, textarea, and pre with dir=auto” is ambiguous. How
about “Any element with dir=auto other than bdo, textarea, and pre” instead?

> Source/WebCore/ChangeLog:21
> +	   (bdo): bdo should use -webkit-override as the default value for
unicode-bidi.

I think you mean “bidi-override”.

> Source/WebCore/ChangeLog:22
> +	   * dom/MappedAttributeEntry.h: Add eBDI, which is used by bdi and
output elements.

Perhaps the name should include “output”?

> Source/WebCore/ChangeLog:28
> +	   in the UA stylesheet now. Also return -webkit-isolate as the default
because now that this function is
> +	   called when dir=auto as the name implies.

Something’s wrong in this last sentence.