[webkit-reviews] review granted: [Bug 73040] FloatQuad::isRectilinear() returns false for 180degree rotations : [Attachment 116761] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 73040: FloatQuad::isRectilinear() returns false for 180degree rotations
https://bugs.webkit.org/show_bug.cgi?id=73040

Attachment 116761: Patch
https://bugs.webkit.org/attachment.cgi?id=116761&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116761&action=review


Thanks for the test. R=me

> Source/WebKit/chromium/tests/FloatQuadTest.cpp:26
> +// FIXME: If we get the TestWebKitAPI framework to bring a full Frame + DOM
stack
> +// in a portable way, this test should be shared with all ports!

this FIXME doesn't really belong in this test - it's not something to do with
this file

> Source/WebKit/chromium/tests/FloatQuadTest.cpp:52
> +    TransformationMatrix nonRectilinearTrans[8];

are there any transformations other than rotations that are interesting for
this logic?