[webkit-reviews] review denied: [Bug 73156] [Microdata] Implement HTMLProprtiesCollection collection.namedItem(). : [Attachment 116721] Updated patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Arko Saha <nghq36 at motorola.com>'s
request for review:
Bug 73156: [Microdata] Implement HTMLProprtiesCollection
collection.namedItem().
https://bugs.webkit.org/show_bug.cgi?id=73156

Attachment 116721: Updated patch
https://bugs.webkit.org/attachment.cgi?id=116721&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116721&action=review


We should be able to do this without custom bindings code.

> Source/WebCore/bindings/v8/custom/V8HTMLPropertiesCollectionCustom.cpp:64
> +    if
(!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty())
> +	   return notHandledByInterceptor();
> +    if (info.Holder()->HasRealNamedCallbackProperty(name))
> +	   return notHandledByInterceptor();

This pattern is very subtle.  Are you sure you've got it right?