[webkit-reviews] review denied: [Bug 73198] [Chromium] Move "final" batch of headers into public/platform : [Attachment 116770] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 09:53:06 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Adam Barth
<abarth at webkit.org>'s request for review:
Bug 73198: [Chromium] Move "final" batch of headers into public/platform
https://bugs.webkit.org/show_bug.cgi?id=73198

Attachment 116770: Patch
https://bugs.webkit.org/attachment.cgi?id=116770&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116770&action=review


sorry, i should have reviewed this more carefully the first time around :-/

> Source/WebKit/chromium/ChangeLog:54
> +	   * public/platform/WebCookie.h: Copied from
Source/WebKit/chromium/public/WebCookie.h.

WebCookie should be moved assuming WebCookieJar is moving.  they go together.

> Source/WebKit/chromium/ChangeLog:58
> +	   * public/platform/WebFont.h: Copied from
Source/WebKit/chromium/public/WebFont.h.

WebFont just looks like it exists to allow the embedder to access WebCore's
font information and font drawing capabilities.
probably isn't required by WebCore.

> Source/WebKit/chromium/ChangeLog:63
> +	   * public/platform/WebImageDecoder.h: Copied from
Source/WebKit/chromium/public/WebImageDecoder.h.

ugh, sorry ... WebImageDecoder is also similarly just about exposing WebCore's
image decoders to the
embedder of webkit.  so, this also shouldn't go into public/platform/, right?

> Source/WebKit/chromium/ChangeLog:65
> +	   * public/platform/WebRegularExpression.h: Copied from
Source/WebKit/chromium/public/WebRegularExpression.h.

ditto for WebRegularExpression

> Source/WebKit/chromium/ChangeLog:76
> +	   * public/platform/WebVideoFrame.h: Copied from
Source/WebKit/chromium/public/WebVideoFrame.h.

it makes sense to move WebVideoFrame assuming WebMediaPlayer is moving too.  i
suspect that is a good idea
since the media player is a lot like the network stack.


More information about the webkit-reviews mailing list