[webkit-reviews] review granted: [Bug 73219] Web Inspector: align agent creation (factory vs constructors). : [Attachment 116762] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 28 08:56:02 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted  review:
Bug 73219: Web Inspector: align agent creation (factory vs constructors).
https://bugs.webkit.org/show_bug.cgi?id=73219

Attachment 116762: Patch
https://bugs.webkit.org/attachment.cgi?id=116762&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116762&action=review


> Source/WebCore/inspector/PageConsoleAgent.h:35
> +#include <wtf/PassOwnPtr.h>

Here and in other places, can you move implementation of the factory methods to
cpp, that way you wouldn't need this include?


More information about the webkit-reviews mailing list