[webkit-reviews] review granted: [Bug 73199] CSSStyleDeclaration: Remove ability to have style sheet as parent. : [Attachment 116723] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 73199: CSSStyleDeclaration: Remove ability to have style sheet as parent.
https://bugs.webkit.org/show_bug.cgi?id=73199

Attachment 116723: Patch
https://bugs.webkit.org/attachment.cgi?id=116723&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=116723&action=review


r=me, with some comments

> Source/WebCore/svg/SVGFontFaceElement.cpp:51
> +class FontFaceStyleDeclaration : public CSSElementStyleDeclaration {
> +public:
> +    FontFaceStyleDeclaration(SVGFontFaceElement* element)

To stick with the coding style, you should have create() for construction.

You should add a comment here explaining why this class is needed and how we
can eventually get rid of it.