[webkit-reviews] review granted: [Bug 73197] [GTK] JavaScriptCore generated sources should build in the DerivedSources directory : [Attachment 116718] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 73197: [GTK] JavaScriptCore generated sources should build in the
DerivedSources directory
https://bugs.webkit.org/show_bug.cgi?id=73197

Attachment 116718: Patch
https://bugs.webkit.org/attachment.cgi?id=116718&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=116718&action=review


Looks good, just a couple of remarks

> Source/JavaScriptCore/GNUmakefile.am:77
> +$(shell mkdir -p DerivedSources/JavaScriptCore)

It's a bit odd to have this here no? Maybe move it to the all-local target of
the top level GNUMakefile.am ?
Also maybe it'd be better like ($mkdir_p)
$(top_builddir)/DerivedSources/JavaScriptCore

> Source/JavaScriptCore/GNUmakefile.am:89
> +	$(PYTHON) $^ > $@

Why remove $(AM_V_GEN) ?