[webkit-reviews] review denied: [Bug 56466] Popup menu can get stuck in closed state when GtkMenu can't grab mouse. : [Attachment 116483] updated as per comments

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Wajahat Siddiqui
<mdwajahatali.siddiqui at motorola.com>'s request for review:
Bug 56466: Popup menu can get stuck in closed state when GtkMenu can't grab
mouse.
https://bugs.webkit.org/show_bug.cgi?id=56466

Attachment 116483: updated as per comments
https://bugs.webkit.org/attachment.cgi?id=116483&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116483&action=review


> Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp:94
> +    if (!gtk_widget_get_visible(m_popup->platformMenu()))
> +	  m_client->failedToShowPopupMenu();
> +

Shouldn't you return early instead of going into a main loop here?