[webkit-reviews] review granted: [Bug 73073] [Chromium] Move the next traunch of headers into public/platform : [Attachment 116488] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 73073: [Chromium] Move the next traunch of headers into public/platform
https://bugs.webkit.org/show_bug.cgi?id=73073

Attachment 116488: Patch
https://bugs.webkit.org/attachment.cgi?id=116488&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116488&action=review


> Source/WebKit/chromium/public/WebGraphicsContext3D.h:-129
> -    virtual bool initialize(Attributes, WebView*, bool
renderDirectlyToWebView) = 0;

we're going to want to unwind this dependency on WebView at some point.

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:53
> +class WebApplicationCacheHost; // FIXME: Does this belong in platform?

the storage systems are interesting.  one approach is to say yes, but we need
to ensure that policy decisions are handled at the Web{Frame,View}Client level
instead.  this is what you would do if it was about access to the filesystem or
network stack, so why not other subsystems like the appcache or indexed db
backend?