[webkit-reviews] review denied: [Bug 73107] Implement CSS hyphenate-limit properties in CSSStyleApplyProperty : [Attachment 116558] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 27 12:20:53 PST 2011


Andreas Kling <kling at webkit.org> has denied  review:
Bug 73107: Implement CSS hyphenate-limit properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=73107

Attachment 116558: Patch
https://bugs.webkit.org/attachment.cgi?id=116558&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116558&action=review


> Source/WebCore/css/CSSStyleApplyProperty.cpp:154
> +	   if (primitiveValue->getIdent() == CSSValueAuto)

This should check against CSSValueNoLimit, not CSSValueAuto, for
CSSPropertyWebkitHyphenateLimitLines.


More information about the webkit-reviews mailing list