[webkit-reviews] review granted: [Bug 73168] CSSStyleRule: Pack m_sourceLine with CSSRule bits. : [Attachment 116672] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 73168: CSSStyleRule: Pack m_sourceLine with CSSRule bits.
https://bugs.webkit.org/show_bug.cgi?id=73168

Attachment 116672: Patch
https://bugs.webkit.org/attachment.cgi?id=116672&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=116672&action=review


r=me, with the stylebot fix.

>> Source/WebCore/css/CSSRule.h:125
>> +	// Only used by CSSStyleRule but kept here to maximize struct packing.
>> +	int m_sourceLine : 27;
> 
> Please declare integral type bitfields with either signed or unsigned. 
[runtime/bitfields] [5]

I think it is nicer to keep the fields together even if it means multiple
private/protected sections. Especially when the fields are being packed.