[webkit-reviews] review denied: [Bug 72846] Implement CSS border image properties in CSSStyleApplyProperty. : [Attachment 116024] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 72846: Implement CSS border image properties in CSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72846

Attachment 116024: Patch
https://bugs.webkit.org/attachment.cgi?id=116024&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116024&action=review


> Source/WebCore/css/CSSStyleApplyProperty.cpp:580
> +	     void (CSSStyleSelector::*mapNinePieceImage)(CSSPropertyID,
CSSValue*, NinePieceImage&)>

This doesn't need to be a template argument, we can just call
mapNinePieceImage() directly.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:587
> +	   if (borderImageType)
> +	       image.setMaskDefaults();

This check should be "if (borderImageType == Mask)" for readability.