[webkit-reviews] review denied: [Bug 72840] Implement Zoom Property in CSSSStyleApplyProperty. : [Attachment 116013] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 72840: Implement Zoom Property in CSSSStyleApplyProperty.
https://bugs.webkit.org/show_bug.cgi?id=72840

Attachment 116013: Patch
https://bugs.webkit.org/attachment.cgi?id=116013&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116013&action=review


> Source/WebCore/css/CSSStyleApplyProperty.cpp:911
> +	   } else if (primitiveValue->primitiveType() ==
CSSPrimitiveValue::CSS_PERCENTAGE) {
> +	       if (float percent = primitiveValue->getFloatValue()) {
> +		   resetEffectiveZoom(selector);
> +		   selector->setZoom(percent / 100.0f);
> +	       }

The applyProperty() version of this code would always reset the effective zoom,
even if getFloatValue() returns 0.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:916
> +	   } else if (primitiveValue->primitiveType() ==
CSSPrimitiveValue::CSS_NUMBER) {
> +	       if (float number = primitiveValue->getFloatValue()) {
> +		   resetEffectiveZoom(selector);
> +		   selector->setZoom(number);
> +	       }

Same here.