[webkit-reviews] review denied: [Bug 72784] Clean up Web Inspector target in Source/WebKit/blackberry/CMakeListsBlackBerry.txt : [Attachment 116651] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Jonathan Dong
<jonathan.dong at torchmobile.com.cn>'s request for review:
Bug 72784: Clean up Web Inspector target in
Source/WebKit/blackberry/CMakeListsBlackBerry.txt
https://bugs.webkit.org/show_bug.cgi?id=72784

Attachment 116651: Patch
https://bugs.webkit.org/attachment.cgi?id=116651&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116651&action=review


I'll r- this, as I have some open questions, and it needs a fixup in the
ChangeLog.

> Source/WebKit/ChangeLog:9
> +		Abstracted the JavaScript file names from
inspector/front-end/inspector.html
> +		to keep them in-sync with the changes of inspector.html.
> +
> +	   Reviewed by NOBODY (OOPS!).

The order is wrong here, It needs to say Reviewed by... then the description
should follow.
Also the indentation is off.

> Source/WebKit/blackberry/CMakeListsBlackBerry.txt:186
> +SET (JS_FILES ${JS_FILES}
${WEBKIT_DIR}/blackberry/WebCoreSupport/inspectorBB.js)

Hm, this seems useful for any CMake based build, no?
How does eg. the Efl port manage this?