[webkit-reviews] review granted: [Bug 73074] StyleGeneratedImage should ref CSSImageGeneratorValue : [Attachment 116631] patch4

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 73074: StyleGeneratedImage should ref CSSImageGeneratorValue
https://bugs.webkit.org/show_bug.cgi?id=73074

Attachment 116631: patch4
https://bugs.webkit.org/attachment.cgi?id=116631&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116631&action=review


r=me. Patch looks great, and I believe you've addressed the issues Nikolas
brought up.

> Source/WebCore/css/CSSImageGeneratorValue.cpp:40
>  CSSImageGeneratorValue::CSSImageGeneratorValue(ClassType classType)

Unrelated to this patch: CSSImageGeneratorValue's ctor and dtor could be
inlined.

> Source/WebCore/css/CSSStyleApplyProperty.cpp:394
> +    typedef T Setter;
> +    typedef T Getter;

I think Setter/Getter are poor names here. SetterType/GetterType perhaps?