[webkit-reviews] review granted: [Bug 59200] [Qt][WK2] Implement permission API for Qt port : [Attachment 116525] Rebased with master, QENUM, etc.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Adenilson Cavalcanti Silva
<adenilson.silva at openbossa.org>'s request for review:
Bug 59200: [Qt][WK2] Implement permission API for Qt port
https://bugs.webkit.org/show_bug.cgi?id=59200

Attachment 116525: Rebased with master, QENUM, etc.
https://bugs.webkit.org/attachment.cgi?id=116525&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116525&action=review


r=me, with Kenneth's comments and my nitpick.

> Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp:85
> +void QtWebPageUIClient::permissionRequest(QWebPermissionRequest *request)

Coding style nitpick: The * placement is wrong.