[webkit-reviews] review granted: [Bug 72947] [Qt] Add support for using OWRT with Qt5 : [Attachment 116608] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 25 06:04:59 PST 2011
Csaba Osztrogonac <ossy at webkit.org> has granted Ádám Kallai
<Kallai.Adam at stud.u-szeged.hu>'s request for review:
Bug 72947: [Qt] Add support for using OWRT with Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947
Attachment 116608: proposed fix
https://bugs.webkit.org/attachment.cgi?id=116608&action=review
------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116608&action=review
LGTM, r=me.
> Tools/Scripts/old-run-webkit-tests:1222
> + if(getQtVersion() lt "5.0") {
only a little nit: missing space after the if.(I'll fix it locally before
landing.)
More information about the webkit-reviews
mailing list