[webkit-reviews] review granted: [Bug 73128] Clean up code in WK2/ChromeClientClient related to viewport handling : [Attachment 116603] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 73128: Clean up code in WK2/ChromeClientClient related to viewport handling
https://bugs.webkit.org/show_bug.cgi?id=73128

Attachment 116603: Patch
https://bugs.webkit.org/attachment.cgi?id=116603&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116603&action=review


r=me but I'll let you decide on cq+ based on the #ifdef comment

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:448
> +#if USE(TILED_BACKING_STORE)
> +    if (m_page->useFixedLayout())
> +	   m_page->resizeToContentsIfNeeded();
> +#endif

For WK2 it does seem a bit strange to have USE(TILED_BACKING_STORE) for this.
Do we actually need the #ifdef?