[webkit-reviews] review denied: [Bug 72947] [Qt] Don't pass -graphicssystem to QtTestBrowser if using Qt5 : [Attachment 116592] proposed fix

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Ádám Kallai
<Kallai.Adam at stud.u-szeged.hu>'s request for review:
Bug 72947: [Qt] Don't pass -graphicssystem to QtTestBrowser if using Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947

Attachment 116592: proposed fix
https://bugs.webkit.org/attachment.cgi?id=116592&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116592&action=review


> Tools/ChangeLog:1
> +2011-11-25  Ádám Kallai  <Kallai.Adam at stud.u-szeged.hu>

It looks like your first name isn't properly utf-8 encoded here. Is that
possible?

> Tools/Scripts/old-run-webkit-tests:242
> +    } elsif (getQtVersion() eq "5.0") {
> +	   $platform = "qt-5.0";

This looks like an unrelated change. Is that intentional?

> Tools/Scripts/old-run-webkit-tests:1224
> -  unshift @configurationArgs, qw(-graphicssystem raster -style windows);
> +  unshift @configurationArgs, qw(-style windows);
> +  if(getQtVersion() lt "5.0") {
> +    unshift @configurationArgs, qw(-graphicssystem raster);
> +  }

This looks much better :). Out of curiosity: Does 'lt' work with strings like
"5.0" like that?