[webkit-reviews] review granted: [Bug 73096] [Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler : [Attachment 116547] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 25 03:59:58 PST 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jesus
Sanchez-Palencia <jesus at webkit.org>'s request for review:
Bug 73096: [Qt][WK2] Refactor GestureRecognizers to use QtWebPageEventHandler
https://bugs.webkit.org/show_bug.cgi?id=73096
Attachment 116547: Patch
https://bugs.webkit.org/attachment.cgi?id=116547&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116547&action=review
> Source/WebKit2/UIProcess/qt/QtPanGestureRecognizer.cpp:53
> + m_eventHandler->interactionEngine()->panGestureCancelled();
Why not make an
private:
inline QtViewportInteractionEngine* interactionEngine() ?
It could be in the class they all inherit from
More information about the webkit-reviews
mailing list