[webkit-reviews] review granted: [Bug 73078] Web Inspector: refactor resource tree model and introduce explicit class for ResourceTreeFrame. : [Attachment 116524] [Patch] First pass of review comments addressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 25 00:38:37 PST 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 73078: Web Inspector: refactor resource tree model and introduce explicit
class for ResourceTreeFrame.
https://bugs.webkit.org/show_bug.cgi?id=73078
Attachment 116524: [Patch] First pass of review comments addressed
https://bugs.webkit.org/attachment.cgi?id=116524&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116524&action=review
> Source/WebCore/inspector/front-end/ResourceTreeModel.js:154
> + if (!framePayload.parentId &&
!WebInspector.networkLog.resources.length) {
Please comment on this logic.
More information about the webkit-reviews
mailing list