[webkit-reviews] review denied: [Bug 70911] Access keys on non visible DOM elements can still be accessed : [Attachment 116492] proposed patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>'s request for review:
Bug 70911: Access keys on non visible DOM elements can still be accessed
https://bugs.webkit.org/show_bug.cgi?id=70911

Attachment 116492: proposed patch
https://bugs.webkit.org/attachment.cgi?id=116492&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116492&action=review


r- since this implements logic that's substantially different from Firefox. I
did not test IE and did not check the spec - please feel free to re-nominate
and explain why this is what we want.

> Source/WebCore/ChangeLog:8
> +	   Access key should only work with visible(visually) elements.

This is incorrect. Access keys work just fine with display:none elements in
Firefox.

The difference with WebKit is that Gecko does not immediately click an element
with accesskey when there are multiple ones with the same assigned key. Firefox
only focuses such elements, and it cycles over others as you repeatedly press
the same access key combination.