[webkit-reviews] review denied: [Bug 72667] [Chromium] Fix broken DRT build for Aura Linux : [Attachment 116478] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 72667: [Chromium] Fix broken DRT build for Aura Linux
https://bugs.webkit.org/show_bug.cgi?id=72667

Attachment 116478: Patch
https://bugs.webkit.org/attachment.cgi?id=116478&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116478&action=review


> Source/WebKit/chromium/WebKit.gyp:756
> +		       'defines': [
> +			   'WTF_USE_GTK'

I think this has to be WTF_USE_GTK=1.  My guess is that's why the test is
failing.

> Tools/DumpRenderTree/DumpRenderTree.gypi:74
> +	       ['(OS=="linux" and toolkit_uses_gtk!="1") or OS=="android"', {

Nit: I think you don't want the "s around the 1.  I think if you fix that, you
don't need the exclude line.  TestShellStub.cpp is only included if it passes
this condition.