[webkit-reviews] review granted: [Bug 72495] [Qt][WK2][Mac] Use Mac port's IPC implementation instead of Unix sockets : [Attachment 116515] patch for review. - changed to use OS(DARWIN)

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 72495: [Qt][WK2][Mac] Use Mac port's IPC implementation instead of Unix
sockets
https://bugs.webkit.org/show_bug.cgi?id=72495

Attachment 116515: patch for review. - changed to use OS(DARWIN)
https://bugs.webkit.org/attachment.cgi?id=116515&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116515&action=review


Looks good to me in general, just wondering about the includes.

> Source/WebKit2/Platform/CoreIPC/Attachment.h:31
> +#include <mach/mach_init.h>
> +#include <mach/mach_traps.h>

Out of curiosity: Why are these includes needed for us (Qt build) and not for
the mac build?

> Source/WebKit2/Platform/mac/WorkQueueMac.cpp:29
> +#include <mach/mach_init.h>

Same here, why do we need the include and not the mac build? Is it because of
precompiled headers?