[webkit-reviews] review denied: [Bug 72947] [Qt] Don't pass -graphicssystem to QtTestBrowser if using Qt5 : [Attachment 116503] proposed fix

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Ádám Kallai
<Kallai.Adam at stud.u-szeged.hu>'s request for review:
Bug 72947: [Qt] Don't pass -graphicssystem to QtTestBrowser if using Qt5
https://bugs.webkit.org/show_bug.cgi?id=72947

Attachment 116503: proposed fix
https://bugs.webkit.org/attachment.cgi?id=116503&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116503&action=review


I think the idea is good. The ChangeLog entry is missing and I have a few
nitpicks :)

> Tools/Scripts/old-run-webkit-tests:242
> +    } elsif (getQtVersion() eq "5.0") {
> +	   $platform = "qt-5.0";

This seems unrelated?

> Tools/Scripts/old-run-webkit-tests:1222
> +  if(!(getQtVersion() ge "5.0")) {

Shouldn't that properly check the major version of Qt only? (if major-version <
4)