[webkit-reviews] review granted: [Bug 73076] Web Inspector: provide context menu items to open resources using extensions : [Attachment 116501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 24 06:31:56 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 73076: Web Inspector: provide context menu items to open resources using
extensions
https://bugs.webkit.org/show_bug.cgi?id=73076

Attachment 116501: Patch
https://bugs.webkit.org/attachment.cgi?id=116501&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116501&action=review


> Source/WebCore/inspector/front-end/HandlerRegistry.js:63
> +    dispatch: function(vararg)

Could we us an single object parameter instead?

> Source/WebCore/inspector/front-end/inspector.js:790
> +    for (var i = 1; i < registry.handlerNames.length; ++i) {

Could you add a comment explaining why we skip first element here?


More information about the webkit-reviews mailing list