[webkit-reviews] review denied: [Bug 59200] [Qt][WK2] Implement permission API for Qt port : [Attachment 116161] Previous fixes, plus Changelog

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Adenilson Cavalcanti Silva
<adenilson.silva at openbossa.org>'s request for review:
Bug 59200: [Qt][WK2] Implement permission API for Qt port
https://bugs.webkit.org/show_bug.cgi?id=59200

Attachment 116161: Previous fixes, plus Changelog
https://bugs.webkit.org/attachment.cgi?id=116161&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=116161&action=review


This is getting there :). I'd like to see the int32 type() thing to get fixed
as well as the request object being scheduled for deletion _before_ the parent
dies. (the parent thing is a last resort, in the common case we should clean up
properly before that)

> Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp:70
> +void QWebPermissionRequest::setAllow(bool accepted)

After calling setAllow, shouldn't the request object get deleted at some point?
(and I mean before the parent QQuickWebView)

> Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h:48
> +    qint32 type() const;

I think the return type should be "Type" and it should be exposed in QML.

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.h:293
> +

Stray newline?