[webkit-reviews] review granted: [Bug 47467] SVG <path> DRT dumps have rounding problems across platforms : [Attachment 116484] Updated patch - v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Nov 24 01:43:48 PST 2011
Zoltan Herczeg <zherczeg at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 47467: SVG <path> DRT dumps have rounding problems across platforms
https://bugs.webkit.org/show_bug.cgi?id=47467
Attachment 116484: Updated patch - v1
https://bugs.webkit.org/attachment.cgi?id=116484&action=review
------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me
View in context: https://bugs.webkit.org/attachment.cgi?id=116484&action=review
> Source/WebCore/svg/SVGPathStringBuilder.cpp:120
> + DEFINE_STATIC_LOCAL(const String, noString, ("0"));
> + DEFINE_STATIC_LOCAL(const String, yesString, ("1"));
I think a simple String::number conversion would be enough here. This seems
overcomplicate things.
More information about the webkit-reviews
mailing list