[webkit-reviews] review denied: [Bug 73005] http-cache can break app-cache's functionality : [Attachment 116329] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Jason
<liuyang12341982 at 163.com>'s request for review:
Bug 73005: http-cache can break app-cache's functionality
https://bugs.webkit.org/show_bug.cgi?id=73005

Attachment 116329: patch
https://bugs.webkit.org/attachment.cgi?id=116329&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Safari does not have this issue.

> But this time it will get the body from http-cache, and the status-code is
304.

This is where the bug is. HTTP cache should not send a 304 over when first
loading an appcache. It would be useless, as it has no data, it has different
headers etc. This is something you need to fix in your network back-end for it
to be usable with WebKit. I guess that you might be adding response body after
304, which made regular browsing work, but that's not how it's supposed to be
implemented.

Note that 304 can be returned when updating appcache (if HTTP cache doesn't
have the response cached). That case is handled right above the line you
modified in this patch.